Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

healthcheck: Rules for checking HEALTHCHECK instructions #567

Merged
merged 1 commit into from Mar 17, 2021

Conversation

m-ildefons
Copy link
Collaborator

  • Add rule DL3012 that makes sure no stage has two HEALTHCHECK
    instructions
  • Add rule DL3057 that makes sure every stage has one HEALTHCHECK
    instruction.
    This rule disabled by default and can be enabled by overriding its
    severity.

fixes #360

What I did

Third time's the charm, right? As promised here #555 (comment), this is the PR with the two rules wrt. HEALTHCHECK instructions.

- Add rule DL3012 that makes sure no stage has two `HEALTHCHECK`
  instructions
- Add rule DL3057 that makes sure every stage has one `HEALTHCHECK`
  instruction.
  This rule disabled by default and can be enabled by overriding its
  severity.

fixes hadolint#360
@lorenzo
Copy link
Member

lorenzo commented Mar 17, 2021

thanks again for such a great contribution :)

@lorenzo
Copy link
Member

lorenzo commented Mar 17, 2021

@m-ildefons do you mind adding the wiki pages?

@lorenzo lorenzo merged commit c74c4f3 into hadolint:master Mar 17, 2021
@m-ildefons
Copy link
Collaborator Author

Sure. I also seem to have lost the entries in the README during one of the rebases. I'll add them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check healthcheck presence
2 participants