New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rule DL3058 for email address format in label schema. #579
Conversation
@lorenzo @m-ildefons - Will make an entry on the wiki corresponding to the link for rule in README once the PR is approved/merged. Let me know of your thoughts. Thanks ! |
hadolint.cabal
Outdated
@@ -3,8 +3,6 @@ cabal-version: 2.0 | |||
-- This file has been generated from package.yaml by hpack version 0.34.2. | |||
-- | |||
-- see: https://github.com/sol/hpack | |||
-- | |||
-- hash: 37f589477154f969b62b2232bb0d1b63a8261cdc7c3b6099f0dcaad7240bc2e7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should not be deleted. Let stack generate this file for you automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lorenzo - I did not delete the hash manually. This seems to be the default behavior for hpack 0.34.2
https://hackage.haskell.org/package/hpack-0.34.0/changelog
For now, I have downgraded my stack version to use the 0.33 hpack so that the hash is still generated. But its bound to come our way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, did not know a new version was out. What version where you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont remember the exact stack version. But the hpack version was 0.34.2 which has the default of no hash strategy.
Thanks so much for your contribution! |
@luckoseabraham can you please add the entry to the wiki? |
|
Thanks! |
What I did
Created a new rule DL3058 for email format validation with label schema.
This is done to manage email values for maintainer label schema.
How I did it
Added a new rule DL3058
How to verify it
Added test cases in Spec.hs