bugfix: avoid index overrun in DL3045 #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo
reviewed
May 11, 2021
src/Hadolint/Rule/DL3045.hs
Outdated
| | Char.isLetter (Text.index path 0) && (':' == Text.index path 1) = True | ||
| | Text.length path >= 2 | ||
| && Char.isLetter (Text.index path 0) | ||
| && (':' == Text.index path 1) = True |
There was a problem hiding this comment.
Is there a version of that function that returns a maybe? We should use that instead
There was a problem hiding this comment.
Not exactly, but uncons is close enough, since this is at the start of path.
- fix index overrun in DL3045 with single character paths when checking for windows type paths. fixes: hadolint#638
m-ildefons
force-pushed
the
index-too-large
branch
from
d460469
to
45e3d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for windows type paths.
fixes: #638