Allow upgrades by removing DL3017, DL3031, DL3039 and adjusting DL3035 #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the late review and thank you so much for the contribution! I merged some things that caused a conflict. Would you mind fixing that? |
|
Merged master and the format seems to have survived. Thanks for the review! Now table format should be correct.. i used the github web-merger first, not very clear regarding line length. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed the rules DL3017, DL3031, DL3039.
Adjusted rule DL3035 to allow upgrades, but not dist-upgrades.
How I did it
Adjusted the rule DL3035 and its test.
Deleted the other rules and their tests.
Removed rules from
Spec.hsandProcess.hs.Updated README,
hadolint.cabalusing hpack, andcontrib/hadolint.json.Why i did it
The rationale of not allowing container upgrades inside containers is outdated (#562) and changes are already made to adjust other rules (#592) following the same advice.