New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Region is not used in the product page URL. #252

Open

1 of 2 tasks

naokiy opened this issue May 5, 2023 · 0 comments

Open

1 of 2 tasks

[BUG] Region is not used in the product page URL. #252

naokiy opened this issue May 5, 2023 · 0 comments

Labels

bug

naokiy commented May 5, 2023 •

edited

Loading

Describe the bug

Even if Region is set to other than Global, the URL generated will be the Global one.
If the book does not exist on amazon.com, the URL will be 404.

It may be due to the presence of "amazon.com" in the following line.
https://github.com/hadynz/obsidian-kindle-plugin/blob/master/src/scraper/scrapeBooks.ts#LL50C7-L50C7

Method of syncing

Amazon Kindle Reader
My Clippings file (please attach file that can be used to recreate issue)

To Reproduce

Steps to reproduce the behaviour:

Set Region to something other than Global.
Sync with Amazon Kindle Reader
See generated file.

Expected behaviour

The URL corresponding to Region is generated.
For example, in Japan, https://www.amazon.co.jp/dp/XXXXXXXX

Metadata

OS: Windows
Plugin version 1.9.2
Obsidian version 1.1.16

naokiy added the bug label

centerfield77 mentioned this issue

Match product page URL to region URL #279

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment