Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'return_numpy' from TableRowClassifier API #20

Closed
haesleinhuepf opened this issue Apr 16, 2022 · 1 comment · Fixed by #22
Closed

Remove 'return_numpy' from TableRowClassifier API #20

haesleinhuepf opened this issue Apr 16, 2022 · 1 comment · Fixed by #22

Comments

@haesleinhuepf
Copy link
Owner

haesleinhuepf commented Apr 16, 2022

I'd like to get rid of the return_numpy parameter here, because:

Instead of this:

result_numpy = table_row_classifier.predict(table, return_numpy=True)

A user could run this:

result_numpy = np.asarray( table_row_classifier.predict(table) )

The second appears more standard to me and it simplifies the API. The other classifers also don't have this parameter.

@kevinyamauchi what do you think about this? Would it be ok to remove it immediately or shall we use some deprecation mechanism? I guess you and me might be the only users as this is relatively young functionality?

@kevinyamauchi
Copy link
Collaborator

Hello @haesleinhuepf ! That is fine with me. No deprecation notice required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants