Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed python 3.7 and opencl from github CI #32

Merged
merged 1 commit into from Aug 24, 2022

Conversation

jo-mueller
Copy link
Contributor

@jo-mueller jo-mueller commented Aug 24, 2022

I think this should fix #28 but I can't know for sure until I've started a run of the github CI.

Edit: Tests are passing, switching to non-draft mode.

Fixes #28

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@391113e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage        ?   91.59%           
=======================================
  Files           ?        4           
  Lines           ?      119           
  Branches        ?        0           
=======================================
  Hits            ?      109           
  Misses          ?       10           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jo-mueller jo-mueller marked this pull request as ready for review August 24, 2022 08:25
@jo-mueller jo-mueller added enhancement New feature or request bug Something isn't working labels Aug 24, 2022
@zoccoler
Copy link
Contributor

Hi Johannes @jo-mueller ,

I like the new test scheme! Just one question: why do we need to remove tests for 3.7?

Best,
Marcelo

@jo-mueller
Copy link
Contributor Author

Hi @zoccoler ,

to be honest, I don't know exactly what's causing this error with 3.7. But it has been seen elsewhere and has also been dropped from tests in napari (see this issue/ PR)

@zoccoler
Copy link
Contributor

Hi @zoccoler ,

to be honest, I don't know exactly what's causing this error with 3.7. But it has been seen elsewhere and has also been dropped from tests in napari (see this issue/ PR)

Sounds good to me then! Can you merge?

@jo-mueller
Copy link
Contributor Author

I can :)

@jo-mueller jo-mueller merged commit 7fff6ff into main Aug 24, 2022
@jo-mueller jo-mueller deleted the remove-python-3.7-and-opencl-from-github-CI branch August 24, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing due to OpenGL installation in test_and_deploy.yaml
2 participants