Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using System.Text.Encoding for encodings? #69

Closed
haf opened this issue Apr 5, 2015 · 2 comments
Closed

Consider using System.Text.Encoding for encodings? #69

haf opened this issue Apr 5, 2015 · 2 comments

Comments

@haf
Copy link
Owner

haf commented Apr 5, 2015

This would mean that you don't have to parse the encoding every request, from string, but instead could pass the actual value you're going to use around.

@relentless
Copy link
Collaborator

I don't know about this, seems that it would put more of a burden on the caller. If it makes the user's job easier, I don't mind a bit of extra parsing on our part.

@haf
Copy link
Owner Author

haf commented Apr 6, 2015

It depends on how you program your code; in all my app code, I already have UTF8 encoding there and ready to use, because I interface with web APIs or write them.

However, how about a withBodyEncodingString (enc : string) ...?

Also, if you are forced to pass a valid encoding, you can rely much more on your compiler and that takes the burden from the programmer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants