code stability test failed in exec/hafs_change_prepbufr_qm_typ.x

[BinLiu-NOAA]

Description

Provide a clear and concise description of the requested feature/capability.
From NCO SPA: During the HAFS v1.0 code stability test, to recompile HAFS code with ‘-check all’ and ‘-ftrapuv’ flag, or using "-check bounds" only.

The code stability test of exec/hafs_change_prepbufr_qm_typ.x failed in either with ‘-check all’ or "-check bounds". Please investigate this failure and address it at the next upgrade.

Here are the detailed info -
/lfs/h1/ops/test/packages/hafs.v1.0.3/sorc.chkall - builds with '-check all'
/lfs/h1/ops/test/packages/hafs.v1.0.3/exec.chk.all - exec with '-check all'/lfs/h1/ops/test/packages/hafs.v1.0.3/sorc.chk.bounds - builds with '-check bounds'
/lfs/h1/ops/test/packages/hafs.v1.0.3/exec.chk.bounds - exec with '-check bounds'

Failed with '-check all'-
/lfs/h1/ops/test/output/20230613/hfsa1_obs_prep_00_NHC_09L_IAN_2022092400.o63085978, obs_prep/prepbufr/hafs_change_prepbufr_qm_typ.out -
forrtl: error (72): floating overflow
Image PC Routine Line Source
hafs_change_prepb 0000000000453ACB Unknown Unknown Unknown
libpthread-2.31.s 000014ADB77628C0 Unknown Unknown Unknown
hafs_change_prepb 00000000004053C9 MAIN__ 117 change_prepbufr_qm_typ.f

Failed with '-check bounds'-
/lfs/f1/ops/para/tmp/hfsa1_00_test_v1.0.0_IAN_09L_2022092400/obs_prep/prepbufr/hafs_change_prepbufr_qm_typ.out -
forrtl: error (72): floating overflow
Image PC Routine Line Source
hafs_change_prepb 0000000000452CDB Unknown Unknown Unknown

Proposed solution

How should the new feature/capability be added? If you have thoughts on the implementation strategy, please share them here.

Status (optional)

Do you (or a colleague) plan to work on adding this feature?

Related to (optional)

Directly reference any related issues or PRs in this or other repositories, and describe how they are related. Examples:

• fixed by hafs-community/hafs/pull/<pr_number>

[BijuThomas-NOAA]

No issue with the debug build or run found on WCOSS2

[ZhanZhang-NOAA]

@BijuThomas-NOAA
Do you mean that the issue has been resolved in the latest UFS/HAFS version? Can we reproduce this bugzilla issue by using the operational HAFSv1?
We can get HAFSv1 from git repository
git clone -b production/hafs.v1 --recursive https://github.com/hafs-community/HAFS.git ./hafs.v1.0.0
or NCO path on WCOSS2
/lfs/h1/ops/prod/packages/hafs.v1.0.5/sorc

[BijuThomas-NOAA]

@ZhanZhang-NOAA The tests I did were for Laura(2020082506-2020082512), and the build with "-check all" and "-ftrapuv" ran successfully. Perhaps, I should have tested IAN (2022092400), which I will do once WCOSS2 is back.

[BijuThomas-NOAA]

The assigned statement RID=RID_8 causes failures when the single precision can not hold large double precision values. Converting RID to double precision to fix this issue. See commit: 432880e.