Check that the send function's "args" parameter is actually an object #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panger95
approved these changes
Jun 12, 2021
Panger95
approved these changes
Jun 12, 2021
duncte123
added a commit
to duncte123/obs-websocket-js
that referenced
this pull request
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue (if applicable):
#223
Description:
This adds a simple check to the
sendfunction to make sure the supplied arguments parameter is actually an object (excluding arrays) and throws an error if not.Added because of the referenced issue above where the author was able to supply an array, which the JavaScript somehow attempts to convert into a (broken) object, which gets sent without a
message-id, and then the plugin returns an error message but because there is nomessage-idthesendfunction gets stuck/hangs.