Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Masking #38

Closed
hageldave opened this issue Mar 27, 2022 · 2 comments
Closed

Key Masking #38

hageldave opened this issue Mar 27, 2022 · 2 comments
Assignees

Comments

@hageldave
Copy link
Owner

hageldave commented Mar 27, 2022

For CoordsysScrollZoom,CoordsysPanning and CoordsysViewSelector, the KeyMaskListener mechanic should allow for the respective action (zooming, panning, area selecting) to happen, if and only if the specified combination of keys is pressed.
This has been implemented as of af38781 , but the most important special case is not covered, which is when no key is required.

When one of the actions should work without key press, we use 0 as argument to the kml constructor.
Now the desired behavior is: when keys are pressed, the mask does not allow for the action to happen.
Currently, the action is allowed in any case, ignoring the pressed keys. This is problematic since it interferes with other actions that do require key presses, which then happen simultaneously.

@hageldave
Copy link
Owner Author

@lvcarx could you please find the commit where this was fixed, comment the hash and close this issue? thanks :)

@lvcarx
Copy link
Collaborator

lvcarx commented Jun 7, 2022

issue was fixed in fdcd4c2

@lvcarx lvcarx closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants