Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade autoconf on the build machines to version 2.72 #10265

Closed
jmairboeck opened this issue Mar 28, 2024 · 5 comments
Closed

upgrade autoconf on the build machines to version 2.72 #10265

jmairboeck opened this issue Mar 28, 2024 · 5 comments

Comments

@jmairboeck
Copy link
Member

The new texlive 2024 (see #10261) requires autoconf 2.72, and it is used in the PATCH function of texlive_core.

Presumably because of haikuports/haikuporter#168, the version installed on the build host (which is currently 2.71) is used instead of the newer version available in the repository.

@korli
Copy link
Contributor

korli commented Mar 29, 2024

IMO using autoconf in PATCH looks suspicious. An additional patch can be added in the patchset

@jmairboeck
Copy link
Member Author

In the patchset, I am patching configure.ac files and then run autoconf in the PATCH function. Should I move that to BUILD instead?

I wrote it like this as BUILD shouldn't modify source files, that is what PATCH is for, IMHO.

@korli
Copy link
Contributor

korli commented Mar 29, 2024

In the patchset, I am patching configure.ac files and then run autoconf in the PATCH function. Should I move that to BUILD instead?

Yes.

I wrote it like this as BUILD shouldn't modify source files, that is what PATCH is for, IMHO.

Generated scripts are not source files.

@jmairboeck
Copy link
Member Author

I moved the autoconf invocation in texlive_core to BUILD in e2f4699.

I leave this open for now because the general issue is still relevant. Although I suppose this can now wait until beta 5 arrives, when an upgrade of the builders is due anyway.

The real fix would be the haikuporter improvement mentioned above, to allow anything to be used in PATCH.

@korli
Copy link
Contributor

korli commented Mar 30, 2024

I don't understand why this issue is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants