Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[batch] Arbitrary pass-through arguments are not supported in hailctl batch submit #13446

Closed
jigold opened this issue Aug 16, 2023 · 2 comments · Fixed by #13447
Closed

[batch] Arbitrary pass-through arguments are not supported in hailctl batch submit #13446

jigold opened this issue Aug 16, 2023 · 2 comments · Fixed by #13447
Assignees
@jigold
Labels
bug

Comments

@jigold
Copy link
Collaborator

jigold commented Aug 16, 2023

What happened?

https://hail.zulipchat.com/#narrow/stream/223457-Hail-Batch-support/topic/How.20to.20use.20hailctl.20batch.20submit.3F/near/385496357

Solution: I think the issue is we're missing this configuration in hailctl batch submit https://typer.tiangolo.com/tutorial/commands/context/#configuring-the-context

Version

0.2.120

Relevant log output

No response
@jigold jigold added the bug label Aug 16, 2023
@jigold jigold self-assigned this Aug 16, 2023
@danking
Copy link
Collaborator

danking commented Aug 16, 2023 •
edited

I have a mild preference for requiring the user to use -- so that we can support this, which is otherwise ambiguous.

hailctl batch --files a_file.txt submit user_script.py -- --files data

danking added a commit to danking/hail that referenced this issue Aug 16, 2023
@danking
[hailctl] clarify suggested use of -- and allow it in hailctl batch s…
5378f93 
…ubmit

CHANGELOG: Resolves hail-is#13446. In all three submit commands (batch, dataproc, and hdinsight), Hail now allows and encourages the use of -- to separate arguments meant for the user script from those meant for hailctl. In hailctl batch submit, option-like arguments, for example "--foo", are now supported before "--" if and only if they do not conflict with a hailctl option.
@danking danking mentioned this issue Aug 16, 2023
Merged
@danking
Copy link
Collaborator

danking commented Aug 16, 2023

In the end, I allowed the extra args approach in the interest of consistency with hailctl dataproc and hailctl hdinsight.

@danking danking changed the title Arbitrary pass-through arguments are not supported in hailctl batch submit [batch] Arbitrary pass-through arguments are not supported in hailctl batch submit Aug 17, 2023
danking added a commit that referenced this issue Aug 18, 2023
@danking
[hailctl] clarify suggested use of -- and allow it in hailctl batch s…
83a6c05 
…ubmit (#13447)

CHANGELOG: Resolves #13446. In all three submit commands (batch,
dataproc, and hdinsight), Hail now allows and encourages the use of --
to separate arguments meant for the user script from those meant for
hailctl. In hailctl batch submit, option-like arguments, for example
"--foo", are now supported before "--" if and only if they do not
conflict with a hailctl option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jigold jigold

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hailctl] clarify suggested use of -- and allow it in hailctl batch submit danking/hail
2 participants
@danking @jigold