Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] ExtractIntervalFilters only supports equality on contigs #14288

Closed
patrick-schultz opened this issue Feb 13, 2024 · 1 comment · Fixed by #14335
Closed

[query] ExtractIntervalFilters only supports equality on contigs #14288

patrick-schultz opened this issue Feb 13, 2024 · 1 comment · Fixed by #14335
Assignees

Comments

@patrick-schultz
Copy link
Collaborator

What happened?

Filtering a locus-keyed dataset will throw an assertion error if any comparison operator other than equality is used on the contig, e.g. mt.locus.contig != 'X'. The relevant assertion is here.

We should add support for at least not-equals. Inequalities would technically also make sense to add, but are probably not likely to be used. If we don't add them, we should at least improve the error.

Version

0.2.127

Relevant log output

No response

@patrick-schultz patrick-schultz added the needs-triage A brand new issue that needs triaging. label Feb 13, 2024
@chrisvittal chrisvittal added bug query and removed needs-triage A brand new issue that needs triaging. labels Feb 21, 2024
@ehigham
Copy link
Collaborator

ehigham commented Feb 21, 2024

reproduction example on a039764:

import hail as hl
mt = hl.balding_nichols_model(1, n_samples=100, n_variants=20)
mt = mt.filter_rows(mt.locus.contig != 'X')
mt.count()

danking pushed a commit that referenced this issue Feb 22, 2024
Fixes: #14288 
All other unsupported comparisons now return top
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants