Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to have baseline, comparison and diff screenshots all in single side by side view? #83

Closed
JasonFairchild opened this issue May 5, 2022 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed HTML

Comments

@JasonFairchild
Copy link

JasonFairchild commented May 5, 2022

Is there a way to have this with this plugin? I've seen it with other approaches, and it seems really visually nice. Sometimes only the diff can be pretty difficult to read. Kinda like this:
image

Vs something like this (this example is probably the simplest using a single file and from cypress-image-snapshot plugin to be clear, but there are potentially a lot of ways to accomplish this I think)
input-cleared diff

@PippoRaimondi
Copy link
Collaborator

yes, that's a good suggestion... we can update the HTML of the report to present it this way... I will wait to see if anyone in the community that is really good with HTML wants to pick this one up, if not I will fix it.

@PippoRaimondi PippoRaimondi added good first issue Good for newcomers help wanted Extra attention is needed HTML labels May 6, 2022
@JasonFairchild
Copy link
Author

Cool. I might be oversimplifying it, but it seems like this example is just taking the 3 images and concatenating them into a single image, with baseline on the left and new shot on the right and the diff between. Sounds pretty straightforward, but not something I have experience with so far.

@kien-ht
Copy link
Collaborator

kien-ht commented Jul 21, 2022

yes, that's a good suggestion... we can update the HTML of the report to present it this way... I will wait to see if anyone in the community that is really good with HTML wants to pick this one up, if not I will fix it.

As of today, it seems like this issue hasn't been fixed yet. My project is also using this plugin, so I'd love to help.

@PippoRaimondi
Copy link
Collaborator

Thanks for contributing @kien-ht ... closing this issue after merging the below:

#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed HTML
Projects
None yet
Development

No branches or pull requests

3 participants