Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different inputs on different monitors #3

Closed
akarnani opened this issue Sep 3, 2020 · 4 comments
Closed

Support different inputs on different monitors #3

akarnani opened this issue Sep 3, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@akarnani
Copy link

akarnani commented Sep 3, 2020

I have two different monitors, and my computers uses different inputs on each. Would it be possible to somehow map the monitor to the desired input in the config file? Something like:

acer123_monitor_input="DisplayPort1"
dell567_monitor_input="Hdmi1"
@haimgel
Copy link
Owner

haimgel commented Sep 3, 2020

This should be possible, and potentially quite a useful improvement. But: this looks like is a significant amount of work, I won't have cycles for this in the short term, sorry.

@haimgel haimgel added the enhancement New feature or request label Sep 3, 2020
@akarnani
Copy link
Author

akarnani commented Sep 3, 2020

Thanks for the response. I looked into achieving this via monitor name, but noticed (at least on my computers) that the Windows ddc api in rust doesn't return useful names. My next solution is to use an array of inputs since the ordering of monitors returned by both the MacOS and Windows apis appear consistent.

However, MacOS does return useful monitor names which could be used in the configuration. However, that would result in the configuration for MacOS and Windows diverging which is (IMO) undesirable.

Would you accept a pull-request which converts monitor_input into an array of input source values? In the case where there are more displays than values provided I propose that the application simply use the first element as a default.

@haimgel
Copy link
Owner

haimgel commented Sep 4, 2020

Thanks for a PR proposal! Yeah, that would work: an array instead of a single value. I agree that monitor order appears to be consistent: my left and right monitors never swap between them, no matter which one I connect first.

I'd prefer the monitor_input config file parameter to be either a single value or an array: that would most probably require a custom deserializer, but OTOH it would be needed anyway for #6

@akarnani
Copy link
Author

Thanks for the fix, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants