Fix #11: prevent serialization of empty collections.

citation-file-format · Feb 24, 2018 · 9ffa72d · 9ffa72d
1 parent 13f0cff
commit 9ffa72d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/cff/model.rb b/lib/cff/model.rb
@@ -122,9 +122,9 @@ def version=(version)
 
     def to_yaml # :nodoc:
       fields = @fields.dup
-      fields['authors'] = array_field_to_yaml(@authors)
-      fields['contact'] = array_field_to_yaml(@contact)
-      fields['keywords'] = @keywords.map { |k| k.to_s }
+      fields['authors'] = array_field_to_yaml(@authors) unless @authors.empty?
+      fields['contact'] = array_field_to_yaml(@contact) unless @contact.empty?
+      fields['keywords'] = @keywords.map { |k| k.to_s } unless @keywords.empty?
 
       YAML.dump fields, :line_width => -1, :indentation => 2
     end

diff --git a/test/cff_model_test.rb b/test/cff_model_test.rb
@@ -178,4 +178,13 @@ def test_keywords_set_and_output_correctly
     assert_equal m.keywords.length, l
     assert y.include? "keywords:\n- one\n- two\n- '3'\n"
   end
+
+  def test_empty_collections_are_not_output
+    m = ::CFF::Model.new('title')
+    y = m.to_yaml
+
+    refute y.include? "authors: []\n"
+    refute y.include? "contact: []\n"
+    refute y.include? "keywords: []\n"
+  end
 end