Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SHA512 instead of SHA1 #2187

Open
galvanopus opened this issue May 15, 2019 · 2 comments
Open

Use SHA512 instead of SHA1 #2187

galvanopus opened this issue May 15, 2019 · 2 comments
Labels
type-idea

Comments

@galvanopus
Copy link

It is not possible to save sample PDF from https://shattered.io/. Only the first one is uploaded as they have the same SHA1.

There is some other news about SHA1: https://mailarchive.ietf.org/arch/msg/cfrg/NhiGvOFzcEw108YLwF_ndyfB1k4

May be it's a time to move to other hashing algorithm? SHA512 looks better because it is quicker than SHA256 on modern CPUs.
@killing killing closed this as completed Sep 16, 2020
@galvanopus
Copy link
Author

@killing Has this been implemented?

@killing
Copy link
Member

killing commented Sep 17, 2020

It's not possible to change the hash function, as so many existing libraries have been created. It cannot be compatible with existing data. I'll leave this open as an idea.

@killing killing reopened this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-idea
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@killing @galvanopus