Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: infodialog tracks as pluginShown even when it doesn't (because of the clean mode) #1078

Closed
jacobwod opened this issue May 5, 2022 · 0 comments
Assignees
Labels
Projects
Milestone

Comments

@jacobwod
Copy link
Member

jacobwod commented May 5, 2022

It turns out that InfoDialog (and perhaps other) plugin will trigger a trackEvent in the Analytics model on page load if it is configured to be visible at start. That's correct, except the situation where the plugin is hidden due to the clean=true query param. In this case we shouldn't track it as shown.

@jacobwod jacobwod added the bug label May 5, 2022
@jacobwod jacobwod added this to the 3.x milestone May 5, 2022
@jacobwod jacobwod self-assigned this May 5, 2022
@jacobwod jacobwod added this to Approved ideas in Hajk via automation May 5, 2022
@jacobwod jacobwod modified the milestones: 3.x, 3.10 May 6, 2022
@jacobwod jacobwod moved this from Approved ideas to Done in Hajk May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Hajk
  
Done
Development

No branches or pull requests

1 participant