Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin: Give LayerInfoDialog artificial breathing #1085

Closed
jesade-vbg opened this issue May 17, 2022 · 5 comments
Closed

Admin: Give LayerInfoDialog artificial breathing #1085

jesade-vbg opened this issue May 17, 2022 · 5 comments
Assignees
@jesade-vbg
Labels
difficulty:easy Functionality is considered easy to port idea module:admin
Projects
Hajk
Milestone
3.10

Comments

@jesade-vbg
Copy link
Contributor

jesade-vbg commented May 17, 2022 •
edited
Loading

If nobody is against it I would like to make some fixes to the layerinfo dialog.
I think it's worth spending an hour or 2 to make it better.
Most fixes will be placed in index.css.

image
@jesade-vbg jesade-vbg changed the title Admin: Give Admin: Give LayerInfoDialog artificial breathing May 17, 2022
@jesade-vbg jesade-vbg self-assigned this May 17, 2022
@jesade-vbg jesade-vbg added module:admin idea difficulty:easy Functionality is considered easy to port labels May 17, 2022
@Hallbergs
Copy link
Member

Go for it :)

@jesade-vbg
Copy link
Contributor Author

The changes does not make it perfect, but it will help.

  • Semitransparent background for dialog (All modal dialogs are affected)
  • It is now possible to scroll the dialog content
  • The info textarea is now bigger
  • Some of the inputs are made wider
  • Labels and inputs are better aligned

image

image

All modal dialogs will get semitransparent background.
image

@jesade-vbg jesade-vbg added this to Approved ideas in Hajk via automation May 18, 2022
@jesade-vbg jesade-vbg added this to the 3.10 milestone May 18, 2022
@jesade-vbg jesade-vbg moved this from Approved ideas to Done in Hajk May 18, 2022
@jacobwod
Copy link
Member

Way better now!

This got me thinking: perhaps we can throw away the ideas for Admin 4 and just keep fixing stuff with CSS in the current version? 🤣 💯 🥇

(Seriously though: good fix @jesade-vbg, our admins are looking forward to it!)

@Hallbergs
Copy link
Member

Looks 🔥🔥🔥

Good job!

@jesade-vbg
Copy link
Contributor Author

Thanx, It was a quick fix.
Oh no @jacobwod 🤣, I don't think it's allowed to joke about that 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesade-vbg jesade-vbg

Labels
difficulty:easy Functionality is considered easy to port idea module:admin
Projects
Hajk
  
Done
Milestone
3.10
Development

No branches or pull requests
3 participants
@jacobwod @Hallbergs @jesade-vbg