Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add close button to Snackbar in Coordinates Plugin #1231

Closed
linusfj opened this issue Nov 4, 2022 · 2 comments · Fixed by #1232
Closed

Add close button to Snackbar in Coordinates Plugin #1231

linusfj opened this issue Nov 4, 2022 · 2 comments · Fixed by #1232
Assignees
@linusfj
Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Projects
Hajk
Milestone
3.11

Comments

@linusfj
Copy link
Member

linusfj commented Nov 4, 2022

Is your feature request related to a problem? Please describe.
When minimizing the Coordinates Plugin on mobile devices, the window is hidden behind the Snackbar and it is difficult to maximize it.

Describe the solution you'd like.
Adding a close button to the Snackbar solves this problem by giving the user access to the maximize button again and without changing the placement of the Snackbar.

Describe alternatives you've considered.
Following the described solution could result in this change.

Before:
image

After:
image
@linusfj linusfj added module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality labels Nov 4, 2022
@linusfj linusfj self-assigned this Nov 4, 2022
@linusfj linusfj mentioned this issue Nov 4, 2022
Merged
@jacobwod jacobwod added this to Approved ideas in Hajk via automation Nov 7, 2022
@jacobwod jacobwod added this to the 3.x milestone Nov 7, 2022
@Hallbergs
Copy link
Member

Nice! The mobile ui is really in need of a redo. (I don't really like how the plugins are handled when minimized etc.). This sorts the problem for now!

@jacobwod jacobwod modified the milestones: 3.x, 3.11 Nov 14, 2022
@jacobwod jacobwod moved this from Approved ideas to Done in Hajk Nov 14, 2022
@Hallbergs
Copy link
Member

Closed via #1232

@Hallbergs Hallbergs linked a pull request Nov 14, 2022 that will close this issue
Feature/snackbar close button #1232
Merged
@jacobwod jacobwod closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linusfj linusfj

Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Projects
Hajk
  
Done
Milestone
3.11
Development

Successfully merging a pull request may close this issue.

Feature/snackbar close button hajkmap/Hajk
3 participants
@jacobwod @linusfj @Hallbergs