Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure smooth upgrade path to NodeJS 18+ #1245

Closed
jacobwod opened this issue Nov 17, 2022 · 2 comments
Closed

Ensure smooth upgrade path to NodeJS 18+ #1245

jacobwod opened this issue Nov 17, 2022 · 2 comments
Assignees
Projects
Milestone

Comments

@jacobwod
Copy link
Member

There have been some security fixes in Node 17 which renders some OpenSSL certificates insecure. So far I've identified two problems that we can run into:

  • building Admin UI fails with this error: Error: error:0308010C:digital envelope routines::unsupported
  • starting Backend with ActiveDirectory active and providing an LDAPS server puls the necessary certificates can require renewed certificates (as OpenSSL 3.0 has tightened the requirements)

This looks as two separate problems. The first one will probably be fixed by bumping some dependencies in Admin. The other one may require providing new, more secure certificates when using LDAPS.

@jacobwod
Copy link
Member Author

The above issue were in fact two separate.

Building Admin UI fails

The reason for this is that we're still on a very old react-scripts version. We have two options here: upgrade to v5 or add a legacy flag. As this Admin is already a legacy product and we're working on its successor, I won't put any effort into upgrading it this late. So a fix with legacy flag is coming up.

Certificates too weak

This must be fixed server-side: you (or someone who provided you with the certs) must use a stronger encryption algorithm. That'll fix the issue.

@jacobwod jacobwod self-assigned this Nov 21, 2022
@jacobwod jacobwod modified the milestones: 3.x, 3.11 Nov 21, 2022
@jacobwod jacobwod moved this from Approved ideas to Done in Hajk Nov 21, 2022
@Hallbergs
Copy link
Member

Legacy flags in the admin UI feels like the correct path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Hajk
  
Done
Development

No branches or pull requests

2 participants