Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change symbol for bookmark or quick link #923

Closed
WCarlsson opened this issue Nov 22, 2021 · 7 comments
Closed

Change symbol for bookmark or quick link #923

WCarlsson opened this issue Nov 22, 2021 · 7 comments
Labels
bug difficulty:easy Functionality is considered easy to port module:client/plugin Functionality that goes into plugins in client needs discussion
Projects
Milestone

Comments

@WCarlsson
Copy link

Is your feature request related to a problem? Please describe.
Bookmark (Bokmärke) and quick link (snabbval) uses the same symbol. This makes it confusing if both of the plugins are set as control buttons since you can´t see a difference until you hover or click on them.

Describe the solution you'd like
Change the symbol for one of the plugins in order to tell them apart when both are control buttons.

Describe alternatives you've considered
If one or both of them are used as a widget or put in the drawer the names show and the fact that they share the same symbol doesn´t impact as much.

@Hallbergs
Copy link
Member

I agree, one of them must change! Do you have any icon-suggestions? :) (https://mui.com/components/material-icons/)

@Hallbergs Hallbergs added bug module:client/plugin Functionality that goes into plugins in client difficulty:easy Functionality is considered easy to port labels Nov 23, 2021
@Hallbergs Hallbergs added this to Approved ideas in Hajk via automation Nov 23, 2021
@Hallbergs Hallbergs added this to the 3.8 milestone Nov 23, 2021
@Hallbergs
Copy link
Member

Hallbergs commented Nov 23, 2021

Suggestions (for the preset plugin):

  • FavoriteIcon
  • StarsIcon

@jacobwod
Copy link
Member

Both would work, I suggest we discuss it on tomorrow's meeting.

@jacobwod
Copy link
Member

Do you have any preference on this, @WCarlsson, @Hallbergs. Another option could be the "Label" or "LabelImportant" icon.

Skärmavbild 2021-11-25 kl  11 54 07

@jacobwod
Copy link
Member

jacobwod commented Nov 25, 2021

Or the FolderSpecial perhaps?

Now we've got some options… 😄
Skärmavbild 2021-11-25 kl  11 55 12

@WCarlsson
Copy link
Author

All good options @jacobwod @Hallbergs !
I feel that Bookmarks can keep the current symbol and that we change Quick link to FolderSpecial or BookmarkBorder

@Hallbergs
Copy link
Member

A fix coming up!

Hajk automation moved this from Approved ideas to Done Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug difficulty:easy Functionality is considered easy to port module:client/plugin Functionality that goes into plugins in client needs discussion
Projects
Hajk
  
Done
Development

No branches or pull requests

3 participants