The pairs of "layer/style" are not sent correctly anymore

[jacobwod]

Prior to #884 we created a correct URL with pairs of layer and corresponding styles like this:

Hajk/new-client/src/plugins/LayerSwitcher/components/LayerGroupItem.js

Line 380 in a81e942

.filter((k) => subLayersToShow.indexOf(k[0]) !== -1)

In #884 that was changed to remove the empty styles:

Hajk/new-client/src/plugins/LayerSwitcher/components/LayerGroupItem.js

Line 381 in 65ca528

(k) => subLayersToShow.indexOf(k[0]) !== -1 && k[1].style !== ""

However, this breaks the custom style functionality completetly, as we don't send correct parings of LAYERS and STYLES.

Prior the change the following parameters were send with the GetMap request (I only show the relevant parts):

LAYERS=fastighetsytor%2Ckvartersnamn%2Ckvartergrans%2Cfastighetsbeteckningar
STYLES=%2Cbmf%3Akvartersnamn%2C%2C

After the change, we get this however:

LAYERS=fastighetsytor%2Ckvartersnamn%2Ckvartergrans%2Cfastighetsbeteckningar
STYLES=bmf%3Akvartersnamn

**It might look similar, but it's not. The commas (encoded as %2C) got removed and now the WMS service gets a request for 4 layers but with only 1 style requested, which breaks the functionality completely. **

[hitomin21]

This might be a difference between QGIS server and Geoserver, I get the opposite problem where if "empty" styles are sent we get incorrect responses, as I described in
#841

I had problems when STYLES=, was sent to the WMS server. Do you get a correct response even when all styles are empty?
@jacobwod

[jacobwod]

This is from GeoServer. Try for yourself. This works but if you remove just one of the commas in STYLE parameter it won't.

[jacobwod]

Do you get a correct response even when all styles are empty? @jacobwod

I do but it is not relevant as a possible (and common) use case is to have a bunch of layers, use default styles (e.g. empty string) on most of them, but override one layer's style with a specific, named style.

[hitomin21]

Thanks, I will have to re-visit what caused the issues for us in that case.