-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intensity ratio algorithm #36
Comments
Hi @joanlyq, The intensity ratio algorithm is not really supported in the released version. It was something we played around with early on, but we found that simple thresholding was effective enough. The The The issue, with the intensity ratio method is that the idea depends on the assumption that the image is of mostly uniform colour, except for areas of glint. Failing that, the idea that the calculated intensity ratio corresponds to the proportion of specular and diffuse reflection in each pixel doesn't really hold up. To overcome that limitation, the authors suggest segmenting different areas of the image first by coloured regions and running the algorithm multiple times for each region. In the end, using the intensity ratio algorithm adds quite a bit of processing overhead to do it properly and it was ultimately abandoned in favour of the naive-yet-effective approach of the ThresholdAlgorithm. |
Hey Taylor, thx for the detailed explanation. It makes sense. I've also tried some other DL glint detector and they all have their own trouble. I totally agree, anything that is effective is good, no need to be complicated. Cheers! |
Hi team, thx for the quick reply last time. I also wanna quickly check with you if the intensity ratio algorithm is unavailable at the moment. I checked both GUI and python library, the RGBIntensityRatioMasker is not working. I tried to dig into the published article a bit but can't seem to find the difference of the threshold and intensity ration masker.
GlintMaskGenerator/glint_mask_generator/glint_algorithms.py
Lines 36 to 46 in 46e8a1f
just by reading this couple of lines, it seems that the intensity ratio is also using the threshold with an additional parameter with diffuse reflectance?
The text was updated successfully, but these errors were encountered: