Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "afterEnd" callback is not called when using "fade" effect #9

Closed
tobium opened this issue Oct 27, 2014 · 6 comments
Closed

The "afterEnd" callback is not called when using "fade" effect #9

tobium opened this issue Oct 27, 2014 · 6 comments

Comments

@tobium
Copy link

tobium commented Oct 27, 2014

You can try it on your demo page: http://hakanersu.github.io/AmaranJS/

I toke a look in the source code and saw that the afterEnd callback is only called when using "slide" effect but not when using "fade" effect...
@hakanersu
Copy link
Owner

Thank you @tobium i will fix in next build.

@tobium
Copy link
Author

tobium commented Oct 27, 2014

how can I contribute?

@hakanersu
Copy link
Owner

You can just edit file in my repo and send a pull request.

@tobium
Copy link
Author

tobium commented Oct 28, 2014

I forked your project and pushed a fix...is it right?

@hakanersu
Copy link
Owner

There is no pull requests right now.Check here for more about pull requests https://help.github.com/articles/using-pull-requests/

@hakanersu
Copy link
Owner

Sorry for delayed fix, it was simple fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hakanersu @tobium