Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Change #20

Closed
PizzaConsole opened this issue Sep 23, 2020 · 5 comments
Closed

License Change #20

PizzaConsole opened this issue Sep 23, 2020 · 5 comments

Comments

@PizzaConsole
Copy link

PizzaConsole commented Sep 23, 2020

I am not sure you are really allowed to Change the License of this code considering it was forked. You do not have copyright permissions to the substantial of the code base. It should stay as MIT

@PizzaConsole
Copy link
Author

Ah never mind, I see what you did:

Fork
This library is forked from DinkToPdf. The main changes are to include the required native binaries in the package so they don't have to be manually installed, and renamed to a move appropriate project name. The license has also been corrected to match the license for the wkhtmltopdf parent project.

Because you include the binaries you have to match the wkhtmltopdf license.

@HakanL
Copy link
Owner

HakanL commented Sep 23, 2020

Yeah, I'm not sure the legality of changing the license (what MIT allows you to do), but since I include the binaries I thought it was more appropriate to mirror the license of the "main" project, vs the wrapper. But I'm no legal expert, if someone needs to audit this prior to them using this project then they should and all details are listed here.

@PizzaConsole
Copy link
Author

@HakanL I think technically you just need to have 2 Licenses, one for the binaries and one for the C# codebase

@PizzaConsole
Copy link
Author

thats what I would do at least

@HakanL
Copy link
Owner

HakanL commented Sep 23, 2020

That may be right, but I don't know how to do that, I don't even think NuGet supports that. I'll leave it for someone else to audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants