Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration #30

Closed
huysentruitw opened this issue Feb 22, 2021 · 2 comments
Closed

Collaboration #30

huysentruitw opened this issue Feb 22, 2021 · 2 comments
Labels
question Further information is requested

Comments

@huysentruitw
Copy link

huysentruitw commented Feb 22, 2021

Hi, I'd like to collaborate a bit on this project.

Things I'd like to improve:

  • limit API surface (now everything is public, even DllImports), I'd like to strip this down to the bare minimum
  • see if we can improve memory handling
  • improve performance
  • start using SemVer + git flow for versioning
  • setup github actions for automatic CI/CD

Perhaps this could all go in as a next major version 2.0. Are you open to contributors and willing to deviate away from DinkToPdf? I could create a fork and call it a day, but it's better to start with an existing user-base for validation.

@HakanL
Copy link
Owner

HakanL commented Feb 25, 2021

Hi @huysentruitw, thanks for your offer (and sorry about the delay in getting back to you).
I think your suggestions are great and would love some help. I don't mind to deviate from DinkToPdf, I forked it just for a project where I needed support for .NET Core and then I finally renamed it to be more "professional".
I have created Github actions for some other OSS I maintain, it could probably be a good starting point, I can look into that. I wasn't able to get auto versioning working well for that, happy to work with you to figure out a solid solution.

@HakanL
Copy link
Owner

HakanL commented Jun 8, 2021

@huysentruitw Feel free to submit PRs for any changes you'd like to see. I've taken steps to deviate from DinkToPdf and implemented Github Actions, so it should be in a good state now to do the changes you suggest. I'm closing this ticket for now since it's more of a question.

@HakanL HakanL closed this as completed Jun 8, 2021
@HakanL HakanL added the question Further information is requested label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants