Making Ladda a AMD/Common.js Module #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2013 10:52
| /* Browser global */ | ||
| else root.Ladda = factory() | ||
| } | ||
| (this, function() { |
There was a problem hiding this comment.
To allow for loading the spin.js file dynamically via requirejs, I had to pass Spinner down into the function with:
(this, function( Spinner ) {
There was a problem hiding this comment.
Argh, I didn't commit the final implementation. Just pushed a fix.
|
Updated to include Spinner in the closures functional call. |
|
+1 for AMD, but why does it look from diff like you changed the whole ladda.js file ? You've also removed Hakim's copyright... |
|
Weird, I'm going to clean this up and do this on a different request. |
|
Moved this to #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves spin.js into it's own file and makes define or export itself as module if using a module loader. otherwise it loads into the window global as before. Retains the exact same functionality but makes loading it cleaner in many environments.