Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the Zone.js RxJS polyfill causes recursion issues #35

Closed
nickjillings opened this issue Nov 16, 2021 · 3 comments
Closed

Using the Zone.js RxJS polyfill causes recursion issues #35

nickjillings opened this issue Nov 16, 2021 · 3 comments
Labels
wontfix This will not be worked on

Comments

@nickjillings
Copy link

nickjillings commented Nov 16, 2021

There is a problem running the tours in apps with the Zone.js Rxjs polyfill included.

Here is a repo
(and stack blitz ).

It seems when the polyfill line import 'zone.js/dist/zone-patch-rxjs'; is included this then throws all kinds of problems, mostly with it recursively calling across the two zones ( and angular). I've tried with both ng-bootstrap and ngx-bootstrap. Haven't used Material as our app uses bootstrap.

In the ngx-bootstrap it seems the directive being included causes the most issues. And in ng-bootstrap it's only when start is called that it throws the error.

@hakimio
Copy link
Owner

hakimio commented Nov 16, 2021

And without the tour all the ng-bootstrap/ngx-bootstrap components/directives used here work as they should? The popover directive itself is not causing those issues?

@hakimio
Copy link
Owner

hakimio commented Nov 16, 2021

To be honest, I would likely blame ng-bootstrap and the polyfill itself for this issue. Don't have the time or will to investigate it more at the moment.
If you find a simple fix, feel free to open a PR.

More info about the ng-bootstrap issue

EDIT: most likely the issue is coming from this ng-bootstrap code.

@hakimio hakimio added the wontfix This will not be worked on label Nov 17, 2021
@hakimio
Copy link
Owner

hakimio commented Nov 19, 2021

Closing since I don't think this is an issue with the ngx-ui-tour itself but 3rd party library (ng-bootstrap).
Possible solutions/workarounds:

  • Don't use the polyfill
  • Create a bug report in ng-bootstrap library to see if they care
  • Use another UI implementation

EDIT: ng-bootstrap has no plans to fix the issue.

@hakimio hakimio closed this as completed Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants