-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide annotation processor as the separate maven artifact. #41
Comments
Anyways, GWT does not include the jar in the final output, as it just compiles out as HTML/CSS/JS so... although this might be a good practice in general, in this case, add nothing, especially bc the processor dependencies are shaded so it cannot conflict with other dependencies. |
It is just suggestion. Now it isn't a real issue, but later it may be a cause of some unpredictable issues in dependency management, so better to think about it. |
@foal I don't fully understand the issue. Can you explain what exactly is wrong? |
Now the annotation processor is in the same project with GWT related classes. Due that the elemento-template jar (and all transitive dependencies) is participating in two different process - code generation and GWT compilation. |
IIUC you want to split maven module
The former would be part of the GWT compilation whereas the latter is only necessary for code generation. This would make it also more obvious which JAR needs to be on the APT classpath. |
Exactly |
Now GWT project depends on annotation processor and vice versa 'maven-compiler-plugin' has GWT related classes in 'annotationProcessorPaths'
The text was updated successfully, but these errors were encountered: