Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify manifest/response spec #89

Merged
merged 1 commit into from Sep 2, 2022
Merged

Conversation

kevinykuo
Copy link
Collaborator

@javierluraschi @anchit-sadana realized we could simplify the json specs a bit, lmk if objection

proposed:

{
    "manifests": [
        {
            "runtime": "r",
            "calls": [
                {
                    "node": "species_dropdown",
                    "fn_name": "on_select",
                    "args": [
                        {
                            "name": "value",
                            "value": "setosa"
                        }
                    ]
                },
                {
                    "node": "summary_table",
                    "fn_name": "html",
                    "args": []
                }
            ]
        }
    ]
}

old:

{
    "manifests": [
        {
            "runtime": "r",
            "nodes": [
                {
                    "name": "species_dropdown",
                    "calls": [
                        {
                            "fn_name": "on_select",
                            "args": [
                                {
                                    "name": "value",
                                    "value": "setosa"
                                }
                            ]
                        }
                    ]
                },
                {
                    "name": "summary_table",
                    "calls": [
                        {
                            "fn_name": "html",
                            "args": []
                        }
                    ]
                }
            ]
        }
    ]
}

@anchit-sadana
Copy link
Contributor

Looks good to me

@kevinykuo kevinykuo merged commit 0f355a1 into hal9ai:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants