Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Parser into two generators #35

Closed
halaxa opened this issue Nov 10, 2020 · 1 comment
Closed

Split Parser into two generators #35

halaxa opened this issue Nov 10, 2020 · 1 comment
Labels
help wanted Extra attention is needed
Milestone

Comments

@halaxa
Copy link
Owner

halaxa commented Nov 10, 2020

  1. Rename Lexer to Tokens
  2. Split Parser into 2 parts
    1. SytnaxCheckedTokens - Will iterate Tokens and will only check syntax of tokens and yield it along
    2. PhpItems - Will iterate SyntaxCheckedTokens and yield php structures

It makes possible to skip syntax checking (to gain speed where applicable) very easilly. User can simply remove SyntaxCheckedTokens from generator stack.

It will also pave way to #36.

@halaxa halaxa added this to the 1.0.0 milestone Nov 10, 2020
@halaxa halaxa added the help wanted Extra attention is needed label Nov 10, 2020
@halaxa halaxa modified the milestones: 1.0.0, 0.6.0 Nov 10, 2020
@halaxa halaxa changed the title Decouple Parser Split Parser into two generators Nov 12, 2020
@halaxa
Copy link
Owner Author

halaxa commented Mar 26, 2021

This will probably be solved differently. Closing for now.

@halaxa halaxa closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant