Question about roughness

[gkouros]

nmf/models/microfacet.py

Line 360 in 3f97cd3

r2 = matprop["r1"][bounce_mask]

Shouldn't the key be "r2" instead of "r1"? Is that a bug or is there a reason behind this?

Also, what do r1 and r2 correspond to? They are the output of the roughness MLP but roughness is usually scalar, so what do the two values correspond to?

Thank you in advance!

[half-potato]

Dear George,
The reason there are 2 roughness values is because I originally wanted to handle anisotropic materials, but I ended up only handling isotropic ones. As a result, I regressed two, but set both to be the same.

[gkouros]

Ok. Makes sense now. Thanks for the quick response!