New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageWrapper should be initialized in halfmoonOnDOMContentLoaded #20
Comments
The However, after reading your comment, I think there could be a use case for the function to actually create these components inside the page automatically. For that, I would probably go with an extra parameter that can be passed onto the function. However, that could lead to some other issues. I will think about this a bit more. Regarding the |
Basically my issue is that
I'm not sure of a best approach for this. I'll be interested to hear your ideas. |
@visoft I am sorry, I misunderstood what you meant before. I think you have found a bug, because the functions would fail in cases where a virtual DOM is being used, and the pageWrapper is not properly initialized. Your solution is probably the best one too. Its not elegant, but it works. I will patch this out ASAP. Thank you so much, really appreciate you bringing this up! |
Hey I implemented your fix and patched the issue with a new release: https://github.com/halfmoonui/halfmoon/releases/tag/v1.0.4. Please let me know if everything works for you as well, I have tested myself and everything seems to be running properly. |
Works great! Thanks for the quick fix! |
I've installed the npm package and am using it with React as shown in the documentation. There is an issue though. I've called
halfmoonOnDOMContentLoaded
, however that function doesn't initializepageWrapper
orstickyAlerts
like it does fordarkModeOn
.I can put in a PR fix this, however how is the npm package built given there is no
package.json
in the project? Should I just alter thehalfmoon.js
file and will you create a new minified version and the npm package?The text was updated successfully, but these errors were encountered: