Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add peak separation #25

Closed
KronosTheLate opened this issue May 11, 2023 · 2 comments
Closed

Add peak separation #25

KronosTheLate opened this issue May 11, 2023 · 2 comments
Labels
question Further information is requested

Comments

@KronosTheLate
Copy link
Contributor

It would be very nice to get an option to get a minimal peak separation, such as that found in https://github.com/tungli/Findpeaks.jl.
@KronosTheLate KronosTheLate mentioned this issue May 11, 2023
Open
@halleysfifthinc
Copy link
Owner

Can you expand on what you mean by minimal peak separation (ideally with an example)? Does the window size argument w not do what you need?

@halleysfifthinc halleysfifthinc added the question Further information is requested label May 11, 2023
@KronosTheLate
Copy link
Contributor Author

KronosTheLate commented May 13, 2023 •
edited
Loading

No, you are absolutely right. Just like for the peakheights issue, I mainly looked at the README to see how to use the package. I also expected a separate function, as the other filtering functions seem to be separate functions. This is closed, and discussion on the discoverability can be continued at #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@halleysfifthinc @KronosTheLate