Wrong local maximum

[judober]

I tried to to find the local maxima of my data with this package. It worked very well except for two points where the results seem wrong. An example with reduced data:

Here is the code to reproduce this with the attached data (with CSV.jl):

w = 327
CSVData = CSV.File("WrongPeak.csv")
x = CSVData.Column1
y = CSVData.Column2
pks, vals = findmaxima(y, w)
plotpeaks(x, y, peaks=pks, scale=:log10)

WrongPeak.csv

Am I doing something wrong here?

[judober]

I looked a bit into what is happening:
it seems the wrong result is identified as a plateau.
However, it is hard for me to tell where it exactly is going wrong.

The good news: with findmaxima(y, w, strict=false), I get the right results.

[halleysfifthinc]

Yep the quick debugging I did on Friday revealed a dumb bug on my part, where the plateau test doesn't check/require that an equal (===) value occurs after the current "peak" candidate. I will push and register a fix this week.