Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: optimize the experience of collapsing the menu #493

Merged
merged 1 commit into from Mar 8, 2022
Merged

perf: optimize the experience of collapsing the menu #493

merged 1 commit into from Mar 8, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 8, 2022

Close halo-dev/halo#1952

  1. 优化折叠菜单时，Logo 和 菜单动画不同步的问题。
  2. 折叠菜单时，缩小 Logo。
  3. 缓存折叠菜单状态。

before:

2022-03-08 15 59 04

after:

2022-03-08 15 57 30

Signed-off-by: Ryan Wang i@ryanc.cc

@ruibaby
perf: optimize the experience of collapsing the menu
dd436ed 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG March 8, 2022 08:01
@ruibaby ruibaby self-assigned this Mar 8, 2022
@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 8, 2022
@ruibaby ruibaby added this to the 1.5.x milestone Mar 8, 2022
JohnNiang
JohnNiang reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

第三点缓存菜单状态指的是什么呢？描述中提供的两个动画中，刷新页面后菜单状态似乎都正常。

@ruibaby
Copy link
Member Author

ruibaby commented Mar 8, 2022

第三点缓存菜单状态指的是什么呢？描述中提供的两个动画中，刷新页面后菜单状态似乎都正常。

before 的截图刷新页面并不会恢复到之前折叠菜单的状态，after 会。

@guqing guqing merged commit 54e5f38 into halo-dev:master Mar 8, 2022
@ruibaby ruibaby deleted the perf/experience-of-collapsing-menu branch March 8, 2022 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing guqing approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@ruibaby ruibaby

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
1.5.x
3 participants
@ruibaby @JohnNiang @guqing