Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate description of pathPattern configuration #15

Open
JohnNiang opened this issue Dec 20, 2023 · 0 comments
Open

Inaccurate description of pathPattern configuration #15

JohnNiang opened this issue Dec 20, 2023 · 0 comments
Labels
kind/improvement Categorizes issue or PR as related to a improvement.

Comments

@JohnNiang
Copy link

In the PR #6, we have supported image zooming based on page rules, but the description of pathPattern below is not accurate.

用于匹配页面路径的正则表达式，如：/archives/**

On the contrary, the rule is based on PathPattern instead of Regex. Thereforce, I request a clearer description of the configuration.

/kind improvement
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohnNiang