Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includeDirs should default to true, as in D, python, unix find, unix ls, etc #18

Open
timotheecour opened this issue Jul 13, 2018 · 2 comments
Labels
breaking Breaking changes will occur as part of closing the issue. discussion [RFC] Fixes, APIs, or changes need feedback. type: feature Request for a new feature or enhancement.

Comments

@timotheecour
Copy link
Collaborator

No description provided.

@timotheecour timotheecour changed the title includeDirs should default to true, as in D, python, unix find includeDirs should default to true, as in D, python, unix find, unix ls, etc Jul 13, 2018
@haltcase haltcase added breaking Breaking changes will occur as part of closing the issue. type: feature Request for a new feature or enhancement. labels Jul 13, 2018
@haltcase
Copy link
Owner

@timotheecour hmm. It seems more common that I'd want to not match directories, and that's what I'm used to from most libraries in the JS realm. This is a possibility but I don't want to be consistent just for the sake of consistency — it should also be sane.

@timotheecour
Copy link
Collaborator Author

not a big deal ultimately whichever way you prefer, however here's 1 more argument:
with current default,
walkGlobKinds only entries with returns kind=file (real or symlink), so (with default options), the kind argument isn't particularly useful
with includeDirs defaulting to true, the kind becomes more meaningful

@haltcase haltcase added the discussion [RFC] Fixes, APIs, or changes need feedback. label Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes will occur as part of closing the issue. discussion [RFC] Fixes, APIs, or changes need feedback. type: feature Request for a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants