Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast values on update #31

Closed
jonataswalker opened this issue Feb 24, 2017 · 3 comments
Closed

Cast values on update #31

jonataswalker opened this issue Feb 24, 2017 · 3 comments
Labels
type: bug Something isn't working as intended or expected.

Comments

@jonataswalker
Copy link

Shouldn't we use this on update:

// this is from `create()`
let insertion = types.toDefinition(this, object)

I have an error trying to update with a boolean value.

@haltcase
Copy link
Owner

@jonataswalker I've pushed a fix - are you able to pull & test to see if it fixes your problem before I publish? I did add a test that works.

@jonataswalker
Copy link
Author

Fix confirmed @citycide. Thanks.

@haltcase
Copy link
Owner

Released in v1.0.0-rc.5.

@haltcase haltcase added the type: bug Something isn't working as intended or expected. label Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as intended or expected.
Projects
None yet
Development

No branches or pull requests

2 participants