Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache driver default doesn't use env CACHE_DRIVER #12

Closed
f-liva opened this issue Jun 8, 2018 · 3 comments
Closed

Cache driver default doesn't use env CACHE_DRIVER #12

f-liva opened this issue Jun 8, 2018 · 3 comments

Comments

@f-liva
Copy link

f-liva commented Jun 8, 2018

From the configuration file laravel-guzzle-throttle.php the driver is set to default as standard, however the default driver set by CACHE_DRIVER in the .env file was ignored and it rises a hamburgscleanest\GuzzleAdvancedThrottle\Exceptions\RedisDatabaseNotSetException.

Everything works correctly if I set the driver value to env('CACHE_DRIVER') instead of 'default'.

Why this behaviour?
@timopruesse
Copy link
Contributor

Hey @fede91it, it's something I probably overlooked while developing because I never changed the environment variable. I'm open for a PR that changes this behavior. Otherwise I'll implement it myself after the weekend. Thanks for bringing that up!

@f-liva
Copy link
Author

f-liva commented Jun 8, 2018

Thank you

@timopruesse timopruesse mentioned this issue Jun 10, 2018
Closed
@timopruesse
Copy link
Contributor

This issue will be solved with hamburgscleanest/laravel-guzzle-throttle#4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f-liva @timopruesse