Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erubis deprecated in Rails 5.1 #121

Closed
bknarendra opened this issue Feb 27, 2017 · 4 comments
Closed

Erubis deprecated in Rails 5.1 #121

bknarendra opened this issue Feb 27, 2017 · 4 comments

Comments

@bknarendra
Copy link

bknarendra commented Feb 27, 2017

Template rendering moved to Erubi in Rails master, this generated a depreciation notice in the HAML gem:

DEPRECATION WARNING: ActionView::Template::Handlers::Erubis is deprecated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead.

@mohitnatoo
Copy link

To add more context to the above description, the latest version of haml-rails seems to have dependency over haml version < 5.0.
We'd need to make use of haml 5.0 instead.

@sergiotapia
Copy link

+1

@k0kubun
Copy link
Member

k0kubun commented May 3, 2017

This is already resolved by #128 and haml/haml@7577c18. Use haml-rails 1.0 and haml 5.0.

And if you use :erb filter in Haml on Rails, you may want to use Haml 5.0.1 because of haml/haml#914.

@syguer
Copy link
Member

syguer commented May 11, 2017

@k0kubun Thanks!

@syguer syguer closed this as completed May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants