Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<refactor> move aws plugins to own plugin #1

Merged
merged 1 commit into from Mar 13, 2020

Conversation

roleyfoley
Copy link
Contributor

Description

This PR implements hamlet-io/engine#1022
To maintain the history of changes to our AWS provider I've cloned the existing cdeontap/gen3 repo into this one and have used this PR to align the repo with a plugin based structure

The repo will contain two plugins aws and awstest

  • aws provides our core aws functionality, resources, services and components
  • awstest provides a unit testing framework through scenarios for the aws provider

Motivation and Context

This change aligns our repo and development structure with the modular architecture which has been implemented in the engine.

How Has This Been Tested?

Tested generation locally for AWS templates, including mock input source and running the test suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Breaking Actions

This change requires the configuration of the GENERATION_PLUGIN_DIRS environment variable to load the AWS plugin if you are running on a local installation

If you have cloned this repo into /opt/codeontap/plugins/aws then you will need to set GENERATION_PLUGIN_DIRS to /opt/codeontap/plugins/aws

If you want to load multiple plugins separate each directory with a ;

Eg. /home/codeontap/cmdb/codeontap/plugins/aws/;/home/codeontap/cmdb/codeontap/plugins/azure/

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ml019 ml019 merged commit b729799 into master Mar 13, 2020
@roleyfoley roleyfoley deleted the refactor-remove-shared-from-plugin branch March 14, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants