Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new components #413

Merged
merged 2 commits into from Sep 27, 2021
Merged

feat: new components #413

merged 2 commits into from Sep 27, 2021

Conversation

ml019
Copy link
Contributor

@ml019 ml019 commented Sep 19, 2021

Intent of Change

  • New feature (non-breaking change which adds functionality)

Description

Add minimal implementations of subscription, hostingplatform and dnszone components. They support the importing of externally created resources.

While commented out, there is also the start of support for dns entry creation for the CDN component for testing of additional resource groups on components.

Minimal support for associated resource types/services has also been added.

Motivation and Context

Part of ADR0007 implementation.

How Has This Been Tested?

Local template generation

Related Changes

Prerequisite PRs:

Dependent PRs:

  • None

Consumer Actions:

  • None

@ml019 ml019 requested a review from a team September 19, 2021 23:40
@ml019 ml019 force-pushed the feat-subscriptions branch 5 times, most recently from e994941 to 0446329 Compare September 26, 2021 12:36
@ml019 ml019 self-assigned this Sep 26, 2021
Add minimal implementations of `subscription`, `hostingplatform`
and `dnszone` components.

While commented out, there is also the start of support for dns
entry creation for the CDN component for testing of additional
resource groups on components.

Minimal support for associated resource types/services has also
been added.
@roleyfoley roleyfoley enabled auto-merge (squash) September 27, 2021 11:10
@roleyfoley roleyfoley merged commit e96b5b0 into hamlet-io:master Sep 27, 2021
@ml019 ml019 deleted the feat-subscriptions branch September 27, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants