Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): support for static routes #57

Merged
merged 3 commits into from Jun 5, 2020
Merged

Conversation

roleyfoley
Copy link
Contributor

Description

Implements hamlet-io/engine#1331 for AWS

To implement this you need to create a couple of things

In the client account:

  • An external service with the transitGateway Id set as the TRANSIT_GATEWAY_ID attribute
  • A Gateway using the router engine with a link to this external service

This will attach the client VPC to the Transit Gateway

In the owner account:

  • A router component
  • An external service with the transitGateway Attachement from the client Id as TRANSIT_GATEWAY_ATTACHMENT attribute
  • An IP address group which represents the client VPC Network
  • A Static Router on the router which links to the external Service for the transit gateway attachment

Motivation and Context

Allows for transit gateways shared between two AWS accounts, the account who has received the transit gateway can only create attachments, routes, routeTables and propagation configuration can only be managed by the account which owns the gateway.

How Has This Been Tested?

Tested on local deployment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@roleyfoley roleyfoley requested a review from a team June 5, 2020 03:09
)]

[#local resources += {
"transitGatewayAttachement" : {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attachement -> Attachment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixeded


[#local resources += {
"transitGatewayAttachement" : {
"Id" : transitGatewayAttachementId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here -maybe go through and global update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixeded

@roleyfoley roleyfoley merged commit 5dcb62a into master Jun 5, 2020
@roleyfoley roleyfoley deleted the router-routetables branch June 5, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants