Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle cmk based encryption at rest #725

Merged
merged 1 commit into from Apr 17, 2023
Merged

fix: handle cmk based encryption at rest #725

merged 1 commit into from Apr 17, 2023

Conversation

roleyfoley
Copy link
Contributor

Intent of Change

  • Bug fix (non-breaking change which fixes an issue)

Description

  • Adds KMS permissions for DynamoDB access when the table is encrypted
  • Adds handling for missing baseline keys when state is being determined

Motivation and Context

  • DynamoDb permissions are added for cases when the default Decrypt permissions are disabled but you need to access a dynamoDb Table. The permissions are more restrictive when using the ones provided via the table state
  • Handling of missing baseline keys is for solutions that have been created in the CMDB before running the baseline deployment. Since occurrences are loaded during the baseline deployment setup the baseline keys couldn't be found and caused issues

How Has This Been Tested?

Tested locally

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

  • None

Consumer Actions:

  • None

@roleyfoley
fix: handle cmk based encryption at rest
e61babf 
- Adds KMS permissions for DynamoDB access when the table is
encrypted
- Adds handling for missing baseline keys when state is being determined
@roleyfoley roleyfoley requested a review from a team April 14, 2023 05:29
@roleyfoley roleyfoley merged commit 8783d9a into hamlet-io:master Apr 17, 2023
2 checks passed
@roleyfoley roleyfoley deleted the fix-encryption-at-rest-policies branch April 17, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@roleyfoley