fix(image): source values #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an image component uses the default configuration, it results in a `Source` attribute value of `Local`. Correct the handling of this value in the image setup, and remove the "registry" value which is not supported via the component configuration.
roleyfoley
force-pushed
the
fix/image-source-values
branch
from
fb58b80
to
84435a8
Compare
roleyfoley
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of Change
Description
When an image component uses the default configuration, it results in a
Sourceattribute value ofLocal. Correct the handling of this value in the image setup, and remove the "registry" value which is not supported via the component configuration.Motivation and Context
Correctly handle image components using a local registry.
How Has This Been Tested?
Customer site
Related Changes
Prerequisite PRs:
Dependent PRs:
Consumer Actions: