Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigateway): private APIs #762

Merged
merged 1 commit into from Jul 3, 2023

Conversation

ml019
Copy link
Contributor

@ml019 ml019 commented Jul 1, 2023

Intent of Change

  • New feature (non-breaking change which adds functionality)

Description

Add support for private APIs, with resource policy control based on vpc endpoints, following the pattern already used for IP address filtering on public APIs.

Consumer VPC endpoints are obtained via inbound links from external services.

Like IP address group support, if no limit is to be placed on where traffic to the API can originate, then an external service with a endpoint value of _global (or equivalent) must be provided.

Motivation and Context

  • support new AWS feature
  • support more security conscious deployment

How Has This Been Tested?

Related Changes

Prerequisite PRs:

Dependent PRs:

  • None

Consumer Actions:

  • None

@ml019 ml019 requested a review from a team July 1, 2023 11:53
@ml019 ml019 force-pushed the feat/api-gateway-private-api branch from d84f965 to 0ed2bb3 Compare July 3, 2023 11:14
@ml019 ml019 changed the title feat(apigateway): prviate APIs feat(apigateway): private APIs Jul 3, 2023
@ml019 ml019 force-pushed the feat/api-gateway-private-api branch from 0ed2bb3 to 8421c35 Compare July 3, 2023 11:18
Add support for private APIs, with resource policy control based on
vpc endpoints, following the pattern already used for IP address
filtering on public APIs.

Consumer VPC endpoints are obtained via inbound links from external
services.

Like IP address group support, if no limit is to be placed on where
traffic to the API can originate, then an external service with a
endpoint value of `_global` (or equivalent) must be provided.
@ml019 ml019 force-pushed the feat/api-gateway-private-api branch from 8421c35 to 4d654c4 Compare July 3, 2023 11:19
@roleyfoley roleyfoley merged commit d37d804 into hamlet-io:master Jul 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants