Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security group references for security groups #78

Merged
merged 1 commit into from Jun 22, 2020

Conversation

roleyfoley
Copy link
Contributor

Description

A minor fix for passing the groupId to ingress rule creation

Motivation and Context

With the recent changes in #73 we have now split the groupId references and the CIDR ranges to separate parameters. This wasn't caught in some of the places we use the ingress rule macro

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@roleyfoley roleyfoley merged commit ac2fcf7 into master Jun 22, 2020
@roleyfoley roleyfoley deleted the fix-security-group-ref branch June 22, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant